Dump "listPlayers" to log.txt

[idk]

Hello!

When i start my script, it needs to know which players are already connected to the server. So the script requests a list of all players by executing the command "listPlayers", but the only output I can see is the in-game console and the server console.

Here is how the JSON-item looks like now:

{"port":27276,"time":73931,"arguments":[],"source":"00000000-0000-0000-0000-000000000000","command":"listPlayers","group":"server","type":"consoleCommandExecute"}

It would have been very nice to write this list to the "log.txt" It would have been ever better if it gave me the same data as "clientAdd" does. If it only gave me playerId, I could loop thru those with some kind of player information command.

[mikesol]

Originally Posted by idk

Hello!

When i start my script, it needs to know which players are already connected to the server. So the script requests a list of all players by executing the command "listPlayers", but the only output I can see is the in-game console and the server console.

Here is how the JSON-item looks like now:

{"port":27276,"time":73931,"arguments":[],"source":"00000000-0000-0000-0000-000000000000","command":"listPlayers","group":"server","type":"consoleCommandExecute"}

It would have been very nice to write this list to the "log.txt" It would have been ever better if it gave me the same data as "clientAdd" does. If it only gave me playerId, I could loop thru those with some kind of player information command.

Why do you need to have list players in the log? Every time a player joins or leaves the server you should be updating your log with the respective information.

For instance in java you might do something like:

private Map<UUID, Integer> playerIdByVaporId = new HashMap<UUID, Integer>();
private Map<Integer, UUID> vaporIdByPlayerId = new HashMap<Integer, UUID>();
private Map<UUID, String> nicknameByVaporId = new HashMap<UUID, String>();

if (CompareHelper.equals(type,"clientAdd")) {

UUID vaporID = UUID.fromString(jsonObject.getString("vaporId"));
String nickname = jsonObject.getString("nickname");
int playerId = jsonObject.getInt("player");
String ip = jsonObject.getString("ip");

String[] parsedIp = ip.split(":");

playerIdByVaporId.put(vaporId, playerId);
vaporIdByPlayerId.put(playerId, vaporId);
nicknameByVaporId.put(vaporId, nickname);

<insert sql code to add player to database here>

...
}

Then when they leave you'd remove them from the respective hashmaps.

[nobodyhome]

Mikesol, you can do it the way you are describing (and it is the way ladder does it), but having a way to get the players currently present in the game is useful if you want to be able to start the script after the server is already up. If the server is already up then you don't know at the moment which players' vaporids are mapped to which JSON log playerId.

[Juin]

Agreed - it makes real-time debugging a royal pain where the sun don't shine, but it's the only way now.

I made a little bash script to check my PHP script's syntax, kill the server, restart it and start my script. Don't mind my crappy bash scripting - I just googled my way into producing what I needed. This works for my mac setup, but you can get the idea and adapt it to your system if you'd like to save some time while debugging and testing.

PHP Code:

#!/bin/bash

lint_output=`php -l myscript.php`

if [ `echo $lint_output | wc -l` =  1 ]; then # no errors = one line
    echo "27276,console,serverMessage Restarting server! Please rejoin!" >> ../servers/command.txt
    sleep 1
    echo "tell application \"server_launcher\" to quit" | osascript # kill the server if it's running
    open ../altitude.app
    open ../server_launcher.app
    php myscript.php
else # display the errors
    echo $lint_output
fi 


[idk]

Just like Nobodyhome said, I dont want to restart the server everytime i got a new version of my script. Since I am using Python, it does compile at run so it's very easy to debug: I just have to execute an in-game command "/script.rs" and then I have the new version up and running in a second.

I think that it would be best if the "listPlayers" only give all "player"-IDs. Otherwise that line will be huge, so I rather grabbing each player's data via another command that needs to be added, it should be giving you the same data as "clientAdd". It would have been also good with another information command that gives you the same data as "spawn". If you would like to add a command to see if tournament is on or off, I would appreciate it

My API is almost finished. Most parts are working but the player manager, which are demanded by some other parts too. I've decied to release it opensourced and I'll post more about that when it has been tested on the ladder servers. There will be some examples provided so it helps you to start your own system, but nothing close to what the ladder servers will use

Thaaanks!

[lamster]

I think the best solution is to start the script before you launch the server (restarting the server if necessary), as this is by far the most elegant and consistent way to track state (otherwise every log entry needs a corresponding chain of commands that can be used to query its current state for hot restart purposes, and that results in twice as much code to maintain both on the generation and parsing side). For testing and hot restarts, the best (though imperfect) solution is usually to parse the existing (old data) in log.txt. That said, I will consider a "logServerStatus" command that prints out a limited snapshot of the current state (maybe connected players and tournament status) so if you have specific requests post them here.

[idk]

If I understood correctly, I should use the "logServerStatus" that gives me a list of player IDs that are currently connected to the server. With those IDs I could get data (same as "clientAdd" gives) of each player by reading thru old data (log.txt). That sounds like a very good idea, thanks!

So, what more could be good to know by using the "logServerStatus"-command? Like we've already mentioned, the status of tournament, is a good candidate.
Could anyone else come up with something good, before Lamster releases an update! I'll think about this over night.

Have a great day!

[Juin]

Including my log-entry suggestions thread here so lamster doesn't forget.

[idk]

Yes, I agree with #3 in your thread, Juin. I got some new statistics that I would like to save, like distance from goal when a player scored and same with TBD mode. I'll positions of all map's goals.

[phong]

If you use a database backend that has tables for servers/current players then you'd be able to restart your script live. The problem of course is if someone joins in the small window the script is being restarted but most scripts are pretty quick.

Just add logic to the script to boot any player that isn't in the table if it comes across a rogue player log entry (say someone joined while the script was restarting).

[idk]

Lamster, could you please add "player" (player ID, not vapor) to the log entry "commandExecution"? Since most other entries do use the players id and so does my player manager. It will save me two loops which now goes thru all connected players after the correct vaporId (the only variable you get from commandExecution) each time someone sends a command.

[Karl]

Originally Posted by idk

Lamster, could you please add "player" (player ID, not vapor) to the log entry "commandExecution"? Since most other entries do use the players id and so does my player manager. It will save me two loops which now goes thru all connected players after the correct vaporId (the only variable you get from commandExecution) each time someone sends a command.

lams might add it but you really should be using a hashmap/hashtable instead of looping through a list (http://en.wikipedia.org/wiki/Hash_table).

It would make sense to be able to look up Player objects via playerId and vaporId. Something like:

HashMap<UUID, Player> playerByVaporId = new HashMap<UUID, Player>();
HashMap<Integer, Player> playerByPlayerId = new HashMap<Integer, Player>();

[Boko]

Originally Posted by Karl

lams might add it but you really should be using a hashmap/hashtable instead of looping through a list (http://en.wikipedia.org/wiki/Hash_table).

It would make sense to be able to look up Player objects via playerId and vaporId. Something like:

HashMap<UUID, Player> playerByVaporId = new HashMap<UUID, Player>();
HashMap<Integer, Player> playerByPlayerId = new HashMap<Integer, Player>();

Since he's coding it in python

http://stackoverflow.com/questions/1...f-a-hash-table

[idk]

Originally Posted by Karl

lams might add it but you really should be using a hashmap/hashtable instead of looping through a list (http://en.wikipedia.org/wiki/Hash_table).

It would make sense to be able to look up Player objects via playerId and vaporId. Something like:

HashMap<UUID, Player> playerByVaporId = new HashMap<UUID, Player>();
HashMap<Integer, Player> playerByPlayerId = new HashMap<Integer, Player>();

Yes, Im using a dictionary, the key is playerId and the value is a playerobject. So ill have to loop thru all keys and check for vaporId inside each playerobject. I rather stick with one list, but thanks for the support, Karl!

Edit: Sorry if I put pressure on you, but could you please tell me when this next update is coming?

[nobodyhome]

If you want to not use a loop, simply use two dictionaries that both have values as playerObjects: one with key playerId and the other with key vaporId. You just have to make sure you insert the playerObject into both dictionaries upon player join.

[idk]

Is it possible to remove the banishment when you're kicking a player? Atleast a option to turn it off. I've also read about a suggestion to add a reason message instead of the current one ("Kicked by server admin"), I would like to support that suggestion too. Thanks